Basically, to put it succinctly, anything that is considered cardio exercise makes Sims lose weight, while strength exercises build muscle. I spent so long having my Sim run on the treadmill wondering why his wish to Become More Muscular wasn't getting fulfilled! Oh well haha.